Skip to content

Vim syntax highlighting and file-type detection#871

Merged
aschackmull merged 3 commits into
github:masterfrom
nickrolfe:vim
Feb 11, 2019
Merged

Vim syntax highlighting and file-type detection#871
aschackmull merged 3 commits into
github:masterfrom
nickrolfe:vim

Conversation

@nickrolfe

Copy link
Copy Markdown
Contributor

I simply copied the ql.vim files from our internal repo and added a minimal readme.

@aschackmull

Copy link
Copy Markdown
Contributor

It looks like there's a bunch of keywords missing, cf. https://help.semmle.com/QL/ql-spec/language.html#summary-of-syntax

Comment thread misc/vim/syntax/ql.vim Outdated
@@ -0,0 +1,42 @@
syn keyword qlKeyword from where select predicate in as order by asc desc module result this super
syn keyword qlAnnotation abstract cached external final library noopt private

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few annotations are missing: deprecated override query pragma language bindingset. Also, if noopt is included then the other annotation args ought to be included as well: noinline nomagic monotonicAggregates.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, added.

@aschackmull aschackmull merged commit be3191a into github:master Feb 11, 2019
@nickrolfe nickrolfe deleted the vim branch February 11, 2019 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants